Impressed with his size and scoring ability, the Vancouver Canucks made the big right winger their 2nd choice, 19th overall in the 1972 NHL Amateur Draft. As a 20-year-old rookie McSheffrey broke into the Canucks' lineup for 33 games, scoring four goals and eight points, but spent the rest of the year with the minor league Seattle Totems. McSheffrey returned for his second year with the Canucks, but in 54 games was able to score just nine times.
Disappointed with his slow development, the organization made McSheffrey part of a big trade with the Buffalo Sabres on October 14, 1974. Vancouver sent McSheffrey and Jocelyn Guevremont to the Sabres for Gerry Meehan and Mike Robitaille.
McSheffrey was unable to crack the Buffalo lineup, managing to appear in just three games in 1974-75. He spent the rest of his season playing 47 games with the Hershey Bears of the AHL where he collected 12 goals and 20 points.
Though McSheffrey would never play in the NHL again, he did play another five years of professional hockey, including the 1975-76 season with the NAHL Buffalo Norsemen. McSheffrey concluded his career by playing two seasons in Holland, making him one of the few North American pro players to play in Holland.